-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix scatter display (alpha/MarkerSize) #58
Conversation
Looks good to me, thank you for the contribution! However, I don't have access to Matlab any longer, so I can't test it. Let's see if @mikelgg93 wants to have a look as well. |
I would love to test it, but unfortunately, I no longer have access to Matlab either. |
Hi there, Sure, here are two figures showing the plots of the test script before and after the commit. And you are correct @mikelgg93, the Example from the test script: I guess I cannot add that commit to this pull request? should I open another one? |
Thank you for your contribution! If you want to make some more changes, feel free to open another pull request. |
Hi there, ah ok, somehow the "MedianMarkerSize" commit was added to this pull request yesterday, without me being aware of it... don't understand why, because I only pushed it to my personal forked repository. But then I don't have anything to pull anymore. |
Great! But that's exactly how pull requests work: You publish a branch in your fork to the main repo. Any change you make to your branch are automatically part of the pull request. So everything worked out! |
thanks for the clarification! so I guess changes I commit to my fork which are not supposed to be merged into your repo, should be done in a separate branch. |
exactly! |
Hi Bastian,
I hope it's ok to create a pull request directly without opening any issues. But I only fixed two minor bugs when plotting the two-sided violins.
First, the alpha was set =1 only for the first (right) violin. And secondly, specifying MarkerSize also affected the first (right) violin only.
And the third change in line 237 is just to keep coding-style consistent.
Best,
Adam